Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Fix Notifications list Margins with the submit button #1500

Merged

Conversation

seshto13
Copy link
Contributor

Description

Increase the right margin or padding on the Notification Settings page to provide sufficient space between the UI elements and the edge of the screen.

Closes #1222
Issue Link : #1222

Changes proposed

What were you told to do?

Increase the right margin or padding on the Notification Settings page to provide sufficient space between the UI elements and the edge of the screen.

What did you do?

I fixed the right margin on the notification settings page to uniformly align and I made sure the consistence is across all screen sizes

Check List (Check all the applicable boxes)

🚨Please review the contribution guideline for this repository.

  • My code follows the code style of this project.
  • This PR does not contain plagiarized content.
  • The title and description of the PR is clear and explains the approach.
  • I am making a pull request against the dev branch (left side).
  • My commit messages styles matches our requested structure.
  • My code additions will fail neither code linting checks nor unit test.
  • I am only making changes to files I was requested to.

Screenshots/Videos

Screen Shot 2024-08-24 at 4 07 49 PM Screen Shot 2024-08-24 at 4 08 38 PM Screen Shot 2024-08-24 at 4 08 54 PM

Copy link
Contributor

github-actions bot commented Aug 24, 2024

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 14.5% 778 / 5365
🔵 Statements 14.17% 780 / 5501
🔵 Functions 14.02% 213 / 1519
🔵 Branches 9.84% 229 / 2325
File CoverageNo changed files found.
Generated in workflow #526

@incredible-phoenix246 incredible-phoenix246 merged commit 22fa81e into hngprojects:dev Aug 25, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Fix]: Adjust Right Margin Under Notifications Page
3 participants